mirror/misskey
1
0
Fork 1
mirror of https://github.com/misskey-dev/misskey.git synced 2024-12-25 22:22:51 +09:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
23,790 Commits 50 Branches 1,053 Tags 350 MiB
c2c2efb7fb
Commit Graph

3271 Commits

Author SHA1 Message Date
okayurisotto
c2c2efb7fb cleanup(ApPersonService.ts) 2023-07-03 20:39:48 +09:00
okayurisotto
a234675eed cleanup(ApPersonService.ts) 2023-07-03 20:39:39 +09:00
okayurisotto
37d5c2c79b refactor(ApPersonService.ts): 可読性の低い三項演算子を削除 
元の実装が悪いと判断し`null`かどうかの確認をより厳密に行うようにした。
 2023-07-03 20:31:12 +09:00
okayurisotto
56a6608741 refactor(ApPersonService.ts) 2023-07-03 20:29:38 +09:00
okayurisotto
8e46204d91 cleanup(ApPersonService.ts) 2023-07-03 20:27:52 +09:00
okayurisotto
9801b20040 cleanup(ApPersonService.ts): 不要なas 2023-07-03 20:27:52 +09:00
okayurisotto
eb0607ec8b cleanup(ApPersonService.ts): 不必要な三項演算子を削除 2023-07-03 20:27:52 +09:00
okayurisotto
09f67204b1 WIP(ApPersonService.ts): 可読性の低い三項演算子を削除しつつnon-null assertionを回避 
エラーメッセージを考える必要がある。
 2023-07-03 20:27:46 +09:00
okayurisotto
afe16d702c refactor(ApQuestionService.ts): function return type 2023-07-03 07:18:09 +09:00
okayurisotto
630078f92e refactor(ApQuestionService.ts): anyを消す 2023-07-03 07:17:56 +09:00
okayurisotto
d0e00c8d17 WIP(ApQuestionService.ts): non-null assertionを消す 
エラーメッセージを考える必要がある。
 2023-07-03 07:15:09 +09:00
okayurisotto
5e715b2105 cleanup(ApQuestionService.ts) 2023-07-03 07:14:11 +09:00
okayurisotto
0f8686dd57 refactor(ApQuestionService.ts): non-null assertionを消した 2023-07-03 07:13:51 +09:00
okayurisotto
279321e841 cleanup(ApQuestionService.ts) 2023-07-03 07:12:03 +09:00
okayurisotto
f70fd08306 refactor(ApQuestionService.ts): eslint-disable-next-line 2023-07-03 07:11:37 +09:00
okayurisotto
fcc60421e2 refactor(ApQuestionService.ts): eslint-disable-next-line 2023-07-03 07:10:47 +09:00
okayurisotto
778585e288 cleanup(ApQuestionService.ts): import 2023-07-03 07:10:01 +09:00
okayurisotto
f4a8e744bf cleanup(ApPersonService.ts) 2023-07-03 06:49:32 +09:00
okayurisotto
8cd1152705 cleanup(ApPersonService.ts): deadcode 2023-07-03 06:49:24 +09:00
okayurisotto
a003fb2707 refactor(ApPersonService.ts): 冗長だった部分を修正 2023-07-03 06:49:02 +09:00
okayurisotto
541429f16b cleanup(ApPersonService.ts) 2023-07-03 06:48:10 +09:00
okayurisotto
f20381d06b refactor(ApPersonService.ts): より実情に即したasに 2023-07-03 06:47:28 +09:00
okayurisotto
5190ef954c cleanup(ApPersonService.ts): import 2023-07-03 06:46:29 +09:00
okayurisotto
451a0e3b48 refactor(ApNoteService.ts): 添付ファイル 2023-07-03 06:14:48 +09:00
okayurisotto
3bd784eac2 cleanup(ApNoteService.ts): anyに対するnon-null assertion 2023-07-03 06:13:39 +09:00
okayurisotto
7a825752f5 cleanup(ApNoteService.ts) 2023-07-03 06:12:40 +09:00
okayurisotto
42b90cd2f1 cleanup(ApNoteService.ts) 2023-07-03 06:12:33 +09:00
okayurisotto
bfc22e9518 cleanup(ApNoteService.ts) 2023-07-03 06:12:26 +09:00
okayurisotto
d8f0d76973 cleanup(ApNoteService.ts): import 2023-07-03 06:12:03 +09:00
okayurisotto
b651fb55dc refactor(ApImageService.ts): JSON.stringify()でのindentationを追加 2023-07-03 06:10:35 +09:00
okayurisotto
244f6720c1 cleanup(ApMentionService.ts): import 2023-07-03 05:46:42 +09:00
okayurisotto
67f9d9db4c refactor(ApImageService.ts): 冗長だった部分を短く 2023-07-03 05:41:51 +09:00
okayurisotto
1454d04c37 cleanup(ApImageService.ts): import 2023-07-03 05:40:12 +09:00
okayurisotto
41fe1b6b1f Revert "WIP(ApImageService.ts): image.urlをgetApHrefNullable()に通すかどうか悩んでいる" 
This reverts commit aeefb843a8.
 2023-07-03 05:39:07 +09:00
okayurisotto
785a5f6f68 WIP(ApPersonService.ts): analyzeAttachments 
- Field型を事前に定義しておくように

- `attachments`が`IObject`だった場合、返り値が`{ fields: [] }`になるようだが構わないのか？
- `toArray()`を通すべきでは？
 2023-07-02 19:15:45 +09:00
okayurisotto
d276dabf26 refactor(ApPersonService.ts): type guardによるnon-null assertionの削除 2023-07-02 19:11:00 +09:00
okayurisotto
a40ea8163e refactor(ApPersonService.ts): function return type 2023-07-02 19:08:41 +09:00
okayurisotto
4535728625 refactor(ApPersonService.ts): eslint-disable-next-line 2023-07-02 19:08:06 +09:00
okayurisotto
be415a96f9 refactor(ApPersonService.ts): eslint-disable-next-line 2023-07-02 19:07:15 +09:00
okayurisotto
8ee31e8002 refactor(ApNoteService.ts): non-null assertion -> optional chaining 2023-07-02 19:06:24 +09:00
okayurisotto
71ca66e24e WIP(ApNoteService.ts): non-null assertion 
non-nullアサーションを減らすために事前に存在確認をするようにした。
エラーをスローするようにしたのでメッセージを考えなければならない。
 2023-07-02 19:05:23 +09:00
okayurisotto
b1ecaecf40 WIP(ApPersonService.ts): as anyをなくした 
エラーをスローするようにせざるを得なかったのでエラーメッセージを考える必要がある。
 2023-07-02 18:34:52 +09:00
okayurisotto
44a1b6d5c0 refactor(ApPersonService.ts): eslint-disable-next-line 2023-07-02 18:20:44 +09:00
okayurisotto
39ad3da62d WIP(ApPersonService.ts): asを調整 
`null`でないか確認する処理が続いていたので型アサーションは`null`とのunionにした。
より本質的な改善の余地があるように感じるのでひとまずWIPとしてコミット。
 2023-07-02 18:20:18 +09:00
okayurisotto
50955427f6 cleanup(ApPersonService.ts): deadcode 2023-07-02 18:09:29 +09:00
okayurisotto
c7fd197efc cleanup(ApPersonService.ts): deadcode 2023-07-02 18:08:47 +09:00
okayurisotto
d3e23d9875 refactor(ApPersonService.ts): function return type 2023-07-02 18:08:23 +09:00
okayurisotto
58abc86def cleanup(ApPersonService.ts): deadcode 2023-07-02 18:07:56 +09:00
okayurisotto
3c17a9b07d cleanup(ApPersonService.ts): no-unused-vars 2023-07-02 18:07:27 +09:00
okayurisotto
8b3641eabe cleanup(ApNoteService.ts): 不要なasを削除 2023-07-02 14:11:51 +09:00