moris/misskey
1
0
Fork 0
forked from mirror/misskey
Code Pull Requests Activity

fix(backend): use atomic command to improve security

Browse Source
This commit is contained in:
syuilo 2024-11-23 04:44:33 +09:00
parent 0e90589290
commit 04b221409c
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/backend/src/core/WebAuthnService.ts
View File

@ -189,14 +189,12 @@ export class WebAuthnService {
*/ */
@bindThis @bindThis
public async verifySignInWithPasskeyAuthentication(context: string, response: AuthenticationResponseJSON): Promise<MiUser['id'] | null> { public async verifySignInWithPasskeyAuthentication(context: string, response: AuthenticationResponseJSON): Promise<MiUser['id'] | null> {
const challenge = await this.redisClient.get(`webauthn:challenge:${context}`); const challenge = await this.redisClient.getdel(`webauthn:challenge:${context}`);
if (!challenge) { if (!challenge) {
throw new IdentifiableError('2d16e51c-007b-4edd-afd2-f7dd02c947f6', `challenge '${context}' not found`); throw new IdentifiableError('2d16e51c-007b-4edd-afd2-f7dd02c947f6', `challenge '${context}' not found`);
} }
await this.redisClient.del(`webauthn:challenge:${context}`);
const key = await this.userSecurityKeysRepository.findOneBy({ const key = await this.userSecurityKeysRepository.findOneBy({
id: response.id, id: response.id,
}); });